HierarchicalTermSelector: Use TextControl component #33545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
Size Change: -51 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
|
It looks like I need to update selectors for e2e tests. |
Mamaduka
force-pushed
the
fix/hierarchical-term-selector-use-textcontrol
branch
from
0c91b36 to
9a9d96e
Compare
ntsekouras
approved these changes
Jul 20, 2021
packages/editor/src/components/post-taxonomies/hierarchical-term-selector.js
Outdated
Show resolved
Hide resolved
That's correct. I will link this comment just for future reference - #33418 (comment). |
sarayourfriend
pushed a commit
that referenced
this pull request
Jul 26, 2021
* Update selector in e2e tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
HierarchicalTermSelectorwasn't using theTextControlcomponent for some of its inputs. As a result, the input fields design was slightly off from the rest of the screen. PR replaces input/labels elements withTextControlcomponent.Fixes #28577.
P.S. The
withInstanceIdHOC is no longer needed for theHierarchicalTermSelectorcomponent but left it here for backward compatibility.How has this been tested?
Screenshots
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).