Card: add missing box-sizing CSS rules
#33511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Feature] Component System
|
Size Change: +1 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
sarayourfriend
approved these changes
Jul 16, 2021
ciampo
force-pushed
the
fix/card-box-sizing
branch
from
b74e167 to
e17939a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #33363 — a regression introduced when migrating to the new g2
<Card />component, where thebox-sizingprop was not added to the<CardFooter />,<CardBody />and<CardHeader />components.When not specified, the value for
box-sizingdefaults tocontent-box, which in turn can cause layout bugs (see for example Automattic/wp-calypso#54445).This PR adds the
box-sizing: border-boxvalue back to all<Card />subcomponents.How has this been tested?
<Card />in Storybook:Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).