Enable the reusable blocks skipped test #33510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #33505
I noticed that when the test failed, the whole page look "selected", so the "ctrl + a" was selecting the whole thing instead of just the focused paragraph block, it meant the paragraph block was not really focused.
I think it was due to the new "overlay" added to reusable blocks, this updates the test to focus the paragraph block properly.
How did I ensure it's not flaky anymore
Locally, I used to have the error once each 5/6 runs. After my changes, I've run the test 24 times without error.