Block editor: iframe: incorporate writing flow #33497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +38 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR restructures writing flow to a purely behavioural hook, which can be used in the iframe component to move the focus capture element out of the iframe (they are not content) and use the iframe body element as the writing flow container, so it removes yet another div wrapper.
Note that for the non-iframed content, it is already the case that the focus capture elements are rendered outside the
.editor-styles-wrapperelement, and this element acts as the writing flow container.How has this been tested?
Writing flow should work correctly in an iframed editor, which means you can arrow navigate between blocks and use tab to navigate in and out of the iframe.
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).