Improve function widgets test #33489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Enhancement
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
kevin940726
force-pushed
the
fix/fucntion-widgets-test
branch
from
6fe2a3f to
49fbbe2
Compare
noisysocks
added
[Type] Build Tooling
talldan
added
[Type] Automated Testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR doesn't have any effect on CI, but should help improving stability of the test locally.
The input in function widget will keep the last entered value after saved. We'll have to clear the input before sending typing command to ensure the we're at the right state.
I also removed some unnecessary
focus()calls since thattype()includes it by default. XPath selectors are also replaced with simpler CSS selectors.How has this been tested?
E2E tests should pass
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).