Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: Set passive listener option for use popover scroll to avoid affecting scrolling performance #33478

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Performance: Set passive listener option for use popover scroll to avoid affecting scrolling performance #33478

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/block-editor/src/components/block-tools/use-popover-scroll.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,12 @@ export function usePopoverScroll( scrollableRef ) {
const { deltaX, deltaY } = event;
scrollableRef.current.scrollBy( deltaX, deltaY );
}
node.addEventListener( 'wheel', onWheel );
// Tell the browser that we do not call event.preventDefault
// See https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#improving_scrolling_performance_with_passive_listeners
const options = { passive: true };
node.addEventListener( 'wheel', onWheel, options );
return () => {
node.removeEventListener( 'wheel', onWheel );
node.removeEventListener( 'wheel', onWheel, options );
};
},
[ scrollableRef ]
Expand Down