Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage folder to .gitignore #33413

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

juanmaguitar
Copy link
Contributor

@juanmaguitar juanmaguitar commented Jul 14, 2021

Description

The coverage folder is not included in the gutenberg repository but this folder is generated every time I run the tests locally and is being tracked by git so you have to be careful not to add this folder in commits.

In this PR I added the coverage folder to .gitignore file so is not being tracked by git anymore

How has this been tested?

By executing commands such as npm run test-unit and checking how the generated coverage folder is ignored by git when doing git status

Types of changes

Minor Git control change.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@gziolo gziolo added Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels Jul 15, 2021
@gziolo
Copy link
Member

gziolo commented Jul 15, 2021

@youknowriad any objections here? We had this folder ignored before, but it was removed together with the default handling for code coverage that we stopped using.

@youknowriad
Copy link
Contributor

I don't mind, but if we can remove its generation entirely, maybe that's better.

@gziolo
Copy link
Member

gziolo commented Jul 15, 2021

I don't think this folder is created by default when you run npm run test-unit, but you can always enable the coverage with a CLI option.

@youknowriad
Copy link
Contributor

got it, let's add the ignore folder, it's fine.

@gziolo
Copy link
Member

gziolo commented Jul 15, 2021

@juanmaguitar, thank you for the contribution 👍🏻

@gziolo gziolo merged commit 29d2f51 into WordPress:trunk Jul 15, 2021
@github-actions github-actions bot added this to the Gutenberg 11.2 milestone Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants