Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the create a block theme how-to guide #33382

Merged
merged 2 commits into from
Jul 26, 2021
Merged

Update the create a block theme how-to guide #33382

merged 2 commits into from
Jul 26, 2021

Conversation

carolinan
Copy link
Contributor

Description

Small update to the "create a block theme" how-to guide,
with updated block names, markup, and margin support in theme.json

Types of changes

Enhancement

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@carolinan carolinan added the [Type] Developer Documentation Documentation for developers label Jul 13, 2021
@carolinan
Update create-block-theme.md
befc6c3 
Correct Gutenberg version number.
@carolinan carolinan requested a review from mkaz July 19, 2021 07:47
jorgefilipecosta
jorgefilipecosta approved these changes Jul 23, 2021
View reviewed changes
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@carolinan carolinan merged commit 36363b9 into trunk Jul 26, 2021
@carolinan carolinan deleted the update/howtoguide-theme branch July 26, 2021 09:07
@github-actions github-actions bot added this to the Gutenberg 11.2 milestone Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgefilipecosta jorgefilipecosta jorgefilipecosta approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@mkaz mkaz Awaiting requested review from mkaz

Assignees
No one assigned
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 11.2
Development

Successfully merging this pull request may close these issues.
2 participants
@carolinan @jorgefilipecosta