Template Part: Avoid button layout shift #33362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Block] Template Part
|
Size Change: +43 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
getdave
approved these changes
Jul 19, 2021
There was a problem hiding this comment.
Tested and this works as described. This should fix the Issue whereby the layout shifts underneath the user which is pretty frustrating for a human and also bad for writing robust e2e tests.
The only thing I wonder about is whether there should be pattern whereby if the network requests takes too long to resolve we show the "New" button early even if the Choose existing hasn't resolved.
Overall however, I think this should ship as it is an improvement.
Thanks for working on this!
|
This looks great, thank you for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR adds a simple loading state while template part replacements are loaded to avoid button layout shift. The layout shift was causing the "Multi-Entity Saving" e2e test to fail from time to time.
See #33169 for complete details.
How has this been tested?
Screenshots
CleanShot.2021-07-12.at.17.19.34.mp4
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).