Plugin: Introduce tools folder with configuration files
#33281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
Gutenberg Plugin
|
Size Change: 0 B Total Size: 1.06 MB ℹ️ View Unchanged
|
gziolo
force-pushed
the
update/introduce-tools-folder
branch
from
205575d to
e7c1034
Compare
gziolo
commented
Jul 8, 2021
|
|
||
| return `./build/[name]/index.min.js`; | ||
| }, | ||
| path: join( __dirname, '..', '..' ), |
There was a problem hiding this comment.
This is the only code change in comparison to the original webpack.config.js file.
youknowriad
reviewed
Jul 8, 2021
There was a problem hiding this comment.
This is looking good, I do wonder whether "tools" is the right name though, it feels this is more "config" than "tools", though both are problematic in some ways:
- tools: what about documentation tool, release tool, api doc tool...
- config: what about the other configs we have spread everywhere :)
|
I followed the pattern that is used in https://github.com/WordPress/wordpress-develop/tree/master/tools
|
youknowriad
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR proposes a new top-level folder with configuration files for tools:
It allows two things:
test/linterfolder totools/eslinttools/webpack/packagesThe next step would be to split webpack config into two subconfigs:
It's similar to what's proposed in WordPress core in WordPress/wordpress-develop#1412.