Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Editor API: Changes to support multiple admin screens in WP 5.8 #33262

Merged
merged 2 commits into from
Jul 12, 2021

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Jul 7, 2021

Description

This PR brings back all the details shared in the dev note https://make.wordpress.org/core/2021/06/16/block-editor-api-changes-to-support-multiple-admin-screens-in-wp-5-8/ into the block editor handbook.

We should land all updates to the block editor handbook before WordPress 5.8 is out (July 20th).

@gziolo gziolo added [Type] Developer Documentation Documentation for developers [Package] Block editor /packages/block-editor labels Jul 7, 2021
@gziolo gziolo self-assigned this Jul 7, 2021
@gziolo gziolo requested review from mkaz, priethor and annezazu July 7, 2021 13:34
Copy link
Contributor

@priethor priethor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the following:

  • Content extended from the original dev note (nice!)
  • Formatting
  • Links

On the other hand, would it be interesting to add notes referencing the filters they replace, as does the dev note? The Handbook is not versioned and attached to specific WP/GB releases and the notes might come in handy for those trying to support older WP versions.

@gziolo
Copy link
Member Author

gziolo commented Jul 8, 2021

On the other hand, would it be interesting to add notes referencing the filters they replace, as does the dev note? The Handbook is not versioned and attached to specific WP/GB releases and the notes might come in handy for those trying to support older WP versions.

Right, I will add the Backward Compatibility section to the document 👍🏻

@gziolo gziolo force-pushed the update/docs-block-editor-screens-filters branch from 3b61c0f to b0a0080 Compare July 12, 2021 12:24
@gziolo gziolo force-pushed the update/docs-block-editor-screens-filters branch from b0a0080 to 80ed454 Compare July 12, 2021 12:25
@gziolo
Copy link
Member Author

gziolo commented Jul 12, 2021

In 80ed454 I added a note informing about deprecated filters:

Screen Shot 2021-07-12 at 14 26 27

Copy link
Contributor

@priethor priethor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉

@gziolo gziolo merged commit f3797c3 into trunk Jul 12, 2021
@gziolo gziolo deleted the update/docs-block-editor-screens-filters branch July 12, 2021 13:46
@github-actions github-actions bot added this to the Gutenberg 11.1 milestone Jul 12, 2021
sarayourfriend pushed a commit that referenced this pull request Jul 15, 2021
…#33262)

* Block Editor API: Changes to support multiple admin screens in WP 5.8
See https://make.wordpress.org/core/2021/06/16/block-editor-api-changes-to-support-multiple-admin-screens-in-wp-5-8/.

* Add a note explaining how to use the deprecated filters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Block editor /packages/block-editor [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants