Fix move to widget area checkmark #33213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
talldan
requested review from
adamziel,
draganescu and
kevin940726
as code owners
|
Size Change: +43 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
kevin940726
approved these changes
Jul 6, 2021
| blockEditorStore | ||
| ); | ||
| const blockParents = getBlockParents( clientId ); | ||
| const widgetAreaClientId = blockParents.find( |
There was a problem hiding this comment.
Nitpick: Maybe we don't need to traverse all the parents because only the first non-null parent would be the widget area block?
There was a problem hiding this comment.
The blockParents are ordered from top to bottom, and find won't traverse the whole array, so I think in essence it'll be pretty much the same. It should in practice always just pick the first array element, but would still work if widget areas had a parent block (not that this will ever happen 😄 ).
Thanks for reviewing.
talldan
added
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jul 6, 2021
* Traverse through block parents to find widget area * Refactor to selector * Switch back to previous selector const * Add doc block
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jul 6, 2021
* Traverse through block parents to find widget area * Refactor to selector * Switch back to previous selector const * Add doc block
youknowriad
pushed a commit
that referenced
this pull request
Jul 7, 2021
* Traverse through block parents to find widget area * Refactor to selector * Switch back to previous selector const * Add doc block
sarayourfriend
pushed a commit
that referenced
this pull request
Jul 15, 2021
* Traverse through block parents to find widget area * Refactor to selector * Switch back to previous selector const * Add doc block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that in
trunk, some blocks don't have a checkmark in the Move To Widget Area dropdown to indicate which widget area they're currently in.This seems to happen to nested blocks. The feature doesn't do a deep search to find the widget area for a block. But I think there's also an issue in that only root level blocks have widget ids, and the widgetId is used to find the widget area.
In this PR I've switched it over to use the client Id and the block editor store to find the widget area for a block. I've made this a selector since the
useLastSelectedWidgetAreahook has exactly the same requirements, and it seems like a useful API to have.How has this been tested?
Screenshots
Before
After
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).