-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor saveEntityRecord from redux-rungen to async thunks #33201
Merged
+275
−232
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
d805236
Migrate saveEntityRecord to thunks
adamziel d227a79
Adjust ifNotResolved tests
adamziel 7a9bd07
Adjust the integration tests
adamziel f0b22c0
Adjust args to select()
adamziel 21410ba
Refactor functions depending on saveEditedEntityRecord to thunks
adamziel 65f3e56
Lint
adamziel f244c96
Adjust saveEntityRecord to deal with async calls instead of generators
adamziel 389910f
Call dispatch.saveEntityRecord instead of dispatch( saveEntityRecord )
adamziel 467c67b
Remove async/await from saveEditedEntityRecord and __experimentalSave…
adamziel 4852128
Make ifNotResolved return an enhanced resolver returning a promise an…
adamziel 6ea2d25
Quality-of-life refactor of __unstableFetch from if to a default argu…
adamziel c214a26
Adjust the second instance of __unstableFetch
adamziel 9ac026a
Adjust the documentation of __unstableFetch to clarify it must be a p…
adamziel 0989625
Remove a commented line
adamziel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Adjust args to select()
- Loading branch information
commit f0b22c0ef848a97a3ff2fb0c9183c56022413991
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This action is also purely synchronous.