Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: Remove withState HOC references #33173

Merged
merged 9 commits into from
Jul 6, 2021
Merged

Documentation: Remove withState HOC references #33173

merged 9 commits into from
Jul 6, 2021

Conversation

Mamaduka
Copy link
Member

@Mamaduka Mamaduka commented Jul 2, 2021 •
edited
Loading

Description

PR replaces the usage of recently deprecated withState HOC with the useState hook.

P.S. I'm thinking of splitting these updates into several PRs to make them easier to review. But let me know if a single PR is preferred.

Types of changes

Documentation update

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@Mamaduka Mamaduka self-assigned this Jul 2, 2021
@Mamaduka Mamaduka added the [Type] Developer Documentation Documentation for developers label Jul 2, 2021
@Mamaduka Mamaduka requested a review from mkaz July 6, 2021 06:06
@Mamaduka Mamaduka force-pushed the update/docs-replace-withstate branch from 693e8d0 to 1c69fad Compare July 6, 2021 07:35
ntsekouras
ntsekouras approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mamaduka !

packages/components/src/higher-order/with-constrained-tabbing/README.md Show resolved Hide resolved
packages/components/src/higher-order/with-focus-return/README.md Show resolved Hide resolved
@Mamaduka
Copy link
Member Author

Mamaduka commented Jul 6, 2021

Thanks for the review, @ntsekouras.

I will start working on the second batch of the updates.

@Mamaduka Mamaduka merged commit 138d5f1 into trunk Jul 6, 2021
@Mamaduka Mamaduka deleted the update/docs-replace-withstate branch July 6, 2021 12:57
@github-actions github-actions bot added this to the Gutenberg 11.1 milestone Jul 6, 2021
This was referenced Jul 6, 2021
Merged
Merged
@mrleemon mrleemon mentioned this pull request Jul 14, 2021
Closed
sarayourfriend pushed a commit that referenced this pull request Jul 15, 2021
@Mamaduka @sarayourfriend
Documentation: Remove withState HOC references (#33173)
c7f7918 
* Update TreeSelect component docs
* Update DropZone component docs
* Update withFocusReturn HOC docs
* Update withConstrainedTabbing HOC docs
* Update DateTimePicker component docs
* Update RadioControl component docs
* Update MenuItemsChoice component docs
* Update TextareaControl component docs
@priethor priethor mentioned this pull request Jul 19, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntsekouras ntsekouras ntsekouras approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@mkaz mkaz Awaiting requested review from mkaz

Assignees

@Mamaduka Mamaduka

Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 11.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Mamaduka @ntsekouras