Try: Polish labels and consolidate options in preferences. #33133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Status] In Progress
|
Size Change: +51 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
|
I like those changes, and I think moving "Appearances" to the General section makes things straightforward. I just found a typo in "Shows text instead of icons in toolbar." (the "the" before toolbar is missing). |
|
Thank you, I fixed the typo. |
|
Regarding that help text "Shows text instead of icons in the toolbar." Because it affects more than one toolbar, I think the singular "toolbar" doesn't seem right. It could be made plural or maybe the text could reduce to "Shows text instead of icons." because "Display button labels" already specifies the context. I think this is much better! We could call it an iteration and merge it. I also think there may still be room for improvement. So I'll share my thoughts but I don't think any of them need to be addressed by this PR. Mainly, I have wondered (since well before this PR) if the settings under "Block Interactions" are where they should be and think they may be equally or more expected to appear under a section of "General". Here's why:
If that seems worth considering here's one take on it: "General" tab reorganized with absorption of settings from "Block interactions"
|
jasmussen
force-pushed
the
try/preferences-polish
branch
from
69b44eb to
2a94d31
Compare
|
Good thoughts, thanks for the review!
I'm hesitant to move the entire "Block interactions" feature into the General section, notably because the contain feature pretty drastically changes the writing flow. Specifically, it stops the arrow-key navigation between blocks:
This is a useful feature for some, but notably not all people. Some screen reader users prefer the caret stops at the end of the block, others might prefer it to have a more page buildery experience. But the feature can also easily be misunderstood and cause frustration when the normal text-editor arrow-key navigation stops working. I wonder if we could expand or rephrase the help text to be clearer? |
It surprises me that the feature could be easily misunderstood. Especially given the help text. Maybe folks don't read help text. As is, I don't suppose the setting is too hard to discover so I'll not argue that point any further. |
stokesman
approved these changes
Jul 6, 2021
|
Thanks as always, @stokesman, much appreciate your time.
I'm projecting. Let me rephrase: every time I see the option I have to remind myself what exactly it does and how it works. That personal failure to consistently grok it is the primary driver for why I think there remains an opportunity to polish that one. That's all. |
sarayourfriend
pushed a commit
that referenced
this pull request
Jul 15, 2021
* Try: Polish labels and consolidate options in preferences. * Fix typo. * Rephrase text labels option. * Update snapshots.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #32922 (comment).
Description
In this PR I've taken a stab at consolidating options in the Preferences dialog, as well as simplify the titles and add descriptive text instead.
I'm marking this one as a draft and in progress, as I expect to tweak the copy and particulars based on feedback.
Before:
After:
Notice how I've merged options from "Appearance" into the "General" section, as all of those options are conceptually related. I'm also not sure it's useful to have an entire section dedicated to just two options — "Display button labels" and "Use theme styles". While it's possible we'll have more options in the future, it doesn't seem that useful to optimize for that until we get there.
Before:
After:
Let me know your thoughts.
Checklist:
*.native.jsfiles for terms that need renaming or removal).