Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover against non existing styles #33127

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Cover against non existing styles #33127

merged 1 commit into from
Jul 1, 2021

Conversation

oandregal
Copy link
Member

Fixes https://github.com/WordPress/gutenberg/pull/32377/files#r662092611

The navigation editor doesn't have 'styles' as part of its settings, but still calls the gutenberg_experimental_global_styles_settings function.

@oandregal oandregal requested a review from spacedmonkey as a code owner July 1, 2021 08:42
@oandregal oandregal self-assigned this Jul 1, 2021
@oandregal oandregal requested a review from talldan July 1, 2021 08:42
@oandregal oandregal added [Type] Bug An existing feature does not function as intended Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Jul 1, 2021
@oandregal oandregal mentioned this pull request Jul 1, 2021
Merged
draganescu
draganescu approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@draganescu draganescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this fix is correct as a defensive measure. One can't guarantee that the key will always be there so let's check for that.

@oandregal oandregal merged commit f9eb406 into trunk Jul 1, 2021
@oandregal oandregal deleted the update/cover-against-lack-of-styles branch July 1, 2021 09:13
@github-actions github-actions bot added this to the Gutenberg 11.1 milestone Jul 1, 2021
@talldan
Copy link
Contributor

talldan commented Jul 5, 2021

Thanks @nosolosw!

@talldan talldan mentioned this pull request Jul 5, 2021
Closed
@talldan talldan mentioned this pull request Jul 13, 2021
Closed
@priethor priethor mentioned this pull request Jul 19, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@draganescu draganescu draganescu approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@talldan talldan Awaiting requested review from talldan

Assignees

@oandregal oandregal

Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 11.1
Development

Successfully merging this pull request may close these issues.
3 participants
@oandregal @talldan @draganescu