Reset z-index on focused widget form #33122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Block] Legacy Widget
|
Size Change: +21 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
tellthemachines
requested review from
talldan,
noisysocks,
kevin940726 and
adamziel
adamziel
approved these changes
Jul 1, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jul 5, 2021
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jul 6, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #33107. The legacy widget form was inheriting a very high z-index value when focused. This fix resets it to 0, same as the non-focused state.
How has this been tested?
In the Widgets editor, insert any legacy widget that displays focusable elements in edit mode (Meta is a good one) and add enough blocks under it to enable scrolling up and down the page. Select the legacy widget and click in its input, then scroll up until the block toolbar overlays the input. Verify that the input goes under the block toolbar.
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).