-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Inserter: Prevent page scroll when searching a block #33012
Conversation
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @walbo! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Thanks for working on this, @walbo. Unfortunately, I'm still able to reproduce the issue after applying a fix from your branch. |
Thanks @Mamaduka The issue is with the use of Have updated the PR and moved the position relative to the content div so it should now handle all use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest update fixes the issue.
Thanks again for working on this, and congrats on your first GB PR 🎉
P.S. I will merge this once all checks are green.
Rebased the branch to hopefully make the CI pass |
Thanks again for working on this PR, @walbo. |
Description
Prevent page scroll when searching in the block inserter.
Fixes #33011
Types of changes
Bug fix
Checklist:
*.native.js
files for terms that need renaming or removal).