Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Inserter: Prevent page scroll when searching a block #33012

Merged
merged 2 commits into from
Jul 1, 2021

Conversation

walbo
Copy link
Member

@walbo walbo commented Jun 27, 2021

Description

Prevent page scroll when searching in the block inserter.

Fixes #33011

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@walbo walbo requested a review from ellatrix as a code owner June 27, 2021 13:00
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jun 27, 2021
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @walbo! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@Mamaduka
Copy link
Member

Thanks for working on this, @walbo.

Unfortunately, I'm still able to reproduce the issue after applying a fix from your branch.

@walbo
Copy link
Member Author

walbo commented Jun 29, 2021

Thanks @Mamaduka

The issue is with the use of VisuallyHidden inside the sidebar. I didn't see that it was also used in the downloadable blocks card at the bottom.

Have updated the PR and moved the position relative to the content div so it should now handle all use of VisuallyHidden in the sidebar.

@Mamaduka Mamaduka added [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Bug An existing feature does not function as intended labels Jun 29, 2021
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest update fixes the issue.

Thanks again for working on this, and congrats on your first GB PR 🎉

P.S. I will merge this once all checks are green.

@Mamaduka Mamaduka changed the title Fix: Prevent page scroll when searching in the block inserter Block Inserter: Prevent page scroll when searching a block Jun 29, 2021
@walbo
Copy link
Member Author

walbo commented Jun 30, 2021

Rebased the branch to hopefully make the CI pass

@Mamaduka Mamaduka merged commit a99c0dd into WordPress:trunk Jul 1, 2021
@github-actions github-actions bot added this to the Gutenberg 11.1 milestone Jul 1, 2021
@Mamaduka
Copy link
Member

Mamaduka commented Jul 1, 2021

Thanks again for working on this PR, @walbo.

@walbo walbo deleted the 33011 branch July 1, 2021 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page scroll when searching for blocks
2 participants