-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle context on edits
#32991
Merged
Merged
Handle context on edits
#32991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indeed, edits should only take default context request (saveEntityRecord calls) into consideration. So this looks good I think. Let's see what the tests say. |
Size Change: +624 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
youknowriad
added
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Jun 25, 2021
ntsekouras
added
[Package] Core data
/packages/core-data
Framework
Issues related to broader framework topics, especially as it relates to javascript
labels
Jun 25, 2021
youknowriad
approved these changes
Jun 25, 2021
Looks like there's something wrong with the logic according to the e2e tests, I'll try to dive deeper :) |
I think I fixed it, let's see. |
jorgefilipecosta
pushed a commit
that referenced
this pull request
Jun 25, 2021
Co-authored-by: Riad Benguella <[email protected]>
youknowriad
added a commit
that referenced
this pull request
Jun 25, 2021
Co-authored-by: Riad Benguella <[email protected]>
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Framework
Issues related to broader framework topics, especially as it relates to javascript
[Package] Core data
/packages/core-data
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update regarding the review here: #32961 (review)