Autocomplete: fix double popover #32988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
ellatrix
requested review from
ajitbohra,
cameronvoell,
chrisvanpatten and
guarani
as code owners
|
Size Change: -1 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
johngodley
approved these changes
Jun 25, 2021
There was a problem hiding this comment.
This solves the problem described in #32986. A 👍 from me. Thanks for the quick fix!
fullofcaffeine
approved these changes
Jun 25, 2021
|
|
||
| return { | ||
| listBoxId, | ||
| activeId, | ||
| onKeyDown: handleKeyDown, | ||
| popover: AutocompleterUI && ( | ||
| popover: hasSelection && AutocompleterUI && ( |
There was a problem hiding this comment.
Could you elaborate a bit more (maybe in the PR description) on why adding this short-circuit here fixed the issue and/or what was in #31718 that introduced it, specifically?
There was a problem hiding this comment.
Sure. Added some more explanation.
|
The failing e2e test is unrelated, is has been failing for a while on other PRs (and |
fullofcaffeine
pushed a commit
that referenced
this pull request
Jun 25, 2021
The popover is rendered twice, once inside the rich text tag and once outside. One of the popovers is removed when rich text is deselected, but the other is not.
|
Cherry-picked to |
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jun 28, 2021
The popover is rendered twice, once inside the rich text tag and once outside. One of the popovers is removed when rich text is deselected, but the other is not.
youknowriad
pushed a commit
that referenced
this pull request
Jun 28, 2021
The popover is rendered twice, once inside the rich text tag and once outside. One of the popovers is removed when rich text is deselected, but the other is not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduced in #31718. Fixes #32986.
The popover is rendered twice, once inside the rich text tag and once outside. One of the popovers is removed when rich text is deselected, but the other is not.
I removed the popover that is rendered outside the tag and added a condition (for selection) for the second popover that is rendered in the tag. In other words, previously there was an
isSelectedcheck, which is now missing.How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).