Avoid adding default block to empty widget areas in customizer #32979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Bug
kevin940726
requested review from
talldan,
tellthemachines,
noisysocks,
adamziel,
draganescu and
getdave
Hmm, seems like it shouldn't do this when edit: ah, I think I see it, |
|
Size Change: +146 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
There might be other things, like the Insert Before / After are no longer available since they insert the default block. Possibly other bits of functionality that's lost too. (edit: the slash inserter also doesn't work)
I feel like this would be good, but we also need the block not to be there in the editor. Maybe an option is an |
talldan
reviewed
Jun 25, 2021
packages/customize-widgets/src/components/sidebar-block-editor/index.js
Outdated
Show resolved
Hide resolved
kevin940726
force-pushed
the
fix/empty-widget-areas-in-customizer
branch
from
bf93753 to
ae1c58b
Compare
kevin940726
commented
Jun 25, 2021
Comment on lines
+24
to
+25
| ! ownerDocument.activeElement || | ||
| ownerDocument.activeElement === ownerDocument.body |
There was a problem hiding this comment.
I'm not sure we need this, but in case if the focus is intentionally moved to other element then we don't want to hijack it either.
talldan
approved these changes
Jun 25, 2021
There was a problem hiding this comment.
This works well.
We know it's not the ideal solution, but it's not too far away IMO, just need to find a way to detect the existence of a custom appender, rather than use a manual setting. And also think about other ways to handle moving the focus to the button appender.
|
E2E failures seem unrelated, I restarted these tests. |
talldan
changed the title
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jun 28, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #32968.
The block editor will inject a default block whenever the content is empty, preventing it from losing focus. This doesn't play nice in the Widgets Customizer though, as an empty block will still create a widget and thus pollute the sidebar. The standalone widgets screen doesn't suffer from this because it will never be emptied, there's always going to be Widget Area blocks.
The solution is to unregister the default block in the customizer, so that the editor won't try to insert a default block whenever the editor is empty. This has a side-effect though as now the focus will be lost after deleting the last block. A possible solution to that would be to manually move the focus to the button block appender whenever that happens.
Another solution to this problem would be to skip creating the empty widget when there's only one block and which is an empty default block. This is more semantically correct and we won't lose the focus. But it might be confusing to the users though 🤔.
I'm open to any other suggestions.
How has this been tested?
Screenshots
Kapture.2021-06-25.at.15.05.39.mp4
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).