Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom classes to archive dropdown #32971

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Add custom classes to archive dropdown #32971

merged 1 commit into from
Jun 24, 2021

Conversation

thisissandip
Copy link
Contributor

Fixes #32870

Description

Add custom classes to archive dropdown

How has this been tested?

  1. Go to Appearance > Widgets
  2. Add a monthly archive block
  3. Format as a dropdown
  4. Add some custom classes in the advanced section
  5. Update the widgets
  6. The custom classes should be there in the front end and in the editor.

Screenshots

image

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@thisissandip thisissandip requested a review from ajitbohra as a code owner June 24, 2021 20:01
@thisissandip thisissandip mentioned this pull request Jun 24, 2021
Closed
@youknowriad youknowriad added [Block] Archives Affects the Archives Block [Type] Bug An existing feature does not function as intended labels Jun 24, 2021
youknowriad
youknowriad approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. Thanks

@youknowriad youknowriad merged commit cde38ac into WordPress:trunk Jun 24, 2021
@github-actions github-actions bot added this to the Gutenberg 11.0 milestone Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
[Block] Archives Affects the Archives Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 11.0
Development

Successfully merging this pull request may close these issues.

Monthly archive dropdown widget doesn't include custom classes.
2 participants
@thisissandip @youknowriad