Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Remove ReactAztecTextInputShadowNodeFork #32940

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

mchowning
Copy link
Contributor

Description

The changes that required the ReactTextInputShadowNodeFork class are now included in theReactTextInputShadowNode class since we've updated to React Native 0.64, so this PR is just removing the no longer needed "Fork" class. There should be no behavior changes in the app.

Additional context for why this code was originally introduced can be found here.

How has this been tested?

  1. Run the demo app
  2. Make sure that there has not been a regression in the padding around RichText inputs (see Remove extra inner padding on text blocks wordpress-mobile/gutenberg-mobile#992)

Types of changes

This is a refactoring that should result in no behavior changes.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

The changes that required that forked class are now included in the
`ReactTextInputShadowNode` class.
Copy link
Contributor

@AmandaRiu AmandaRiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Android and iOS and padding looks good! 👍 LGTM :shipit:

@mchowning mchowning merged commit 0d0dc1e into trunk Jun 25, 2021
@mchowning mchowning deleted the remove-shadow-node-fork branch June 25, 2021 15:15
@github-actions github-actions bot added this to the Gutenberg 11.0 milestone Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants