Fix: template editor header area is difficult to navigate with screenreaders #32938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Focus] Accessibility (a11y)
|
Size Change: +20 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
|
Code changes look good, I will give it a try and report back. |
carolinan
approved these changes
Jun 24, 2021
gziolo
approved these changes
Jun 24, 2021
There was a problem hiding this comment.
It works correctly, nice work @jorgefilipecosta :
Screen.Recording.2021-06-24.at.16.31.05.mov
youknowriad
deleted the
fix/template-editor-header-area-is-difficult-to-navigate-with-screen-readers
branch
youknowriad
pushed a commit
that referenced
this pull request
Jun 25, 2021
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #32642
This PR applies some changes to the template title and dropdown menu on the post editor to make it more accessible.
How has this been tested?
I verified that the button to go back to post editor and the button to open the template options are both tabbable and their tab order respects their visual order.