Navigation: Update the function name and correct the comment #32918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
talldan
reviewed
Jun 23, 2021
| * | ||
| * @param array $location The location of the classic menu to display. | ||
| * @param array $attributes Navigation block attributes. | ||
| * @return string|false HTML markup of a generated Navigation Block or false if no location is specified. | ||
| */ | ||
| function render_classic_location_menu( $location, $attributes ) { | ||
| function gutenberg_render_menu_from_location( $location, $attributes ) { |
There was a problem hiding this comment.
@scruffian Just noticed that these two lines look to be unused in the function as well:
$block_attributes = $attributes;
unset( $block_attributes['__unstableLocation'] );And it looks like the second $attributes param/argument to the function can be dropped too.
There was a problem hiding this comment.
You're right, thanks. Done!
|
Thanks! :) |
mtias
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes a function name and corrects an incorrect comment from #32491.
How has this been tested?
Using Quadrat, which implements this attribute
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).