Fix eslint-import resolver with extraneous dependencies #32906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
the
[Type] Bug
|
Size Change: +1 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
The It looks like the update to the package is all that is necessary. |
gziolo
added
the
[Type] Automated Testing
Oh cool, didn't know that, will update. |
gziolo
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Originally reported in #31792 (comment)
This fixes an issue #31792 introduced when importing a
@wordpress/*dependency without listing it inpackage.jsondoesn't report error in ESLint.The solution is in the rule
import/no-extraneous-dependencies. Had to update the plugin so that it can correctly walk up to the correctpackage.json(import-js/eslint-plugin-import#1174, import-js/eslint-plugin-import#1696).I wonder if this rule should be enabled in the scope of the@wordpress/eslint-pluginpackage? Seems pretty helpful to me.How has this been tested?
Add a random
@wordpress/*dependency in a package without listing it inpackage.json. It should show error when runningnpm run lint-jsor in your code editor.Screenshots
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).