Stretch Widgets editor layout to full height #32905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
requested review from
adamziel,
draganescu,
kevin940726,
noisysocks and
talldan
as code owners
tellthemachines
added
[Feature] Widgets Screen
|
Size Change: +78 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
talldan
added
the
Backport to WP 6.7 Beta/RC
kevin940726
approved these changes
Jun 23, 2021
Comment on lines
+9
to
+19
| display: flex; | ||
| flex-direction: column; | ||
| flex-grow: 1; | ||
|
|
||
| > div:last-of-type, | ||
| .block-editor-writing-flow, | ||
| .block-editor-writing-flow > div { | ||
| display: flex; | ||
| flex-direction: column; | ||
| flex-grow: 1; | ||
| } |
There was a problem hiding this comment.
Could we do this?
Suggested change
| display: flex; | |
| flex-direction: column; | |
| flex-grow: 1; | |
| > div:last-of-type, | |
| .block-editor-writing-flow, | |
| .block-editor-writing-flow > div { | |
| display: flex; | |
| flex-direction: column; | |
| flex-grow: 1; | |
| } | |
| &, | |
| > div:last-of-type, | |
| .block-editor-writing-flow, | |
| .block-editor-writing-flow > div { | |
| display: flex; | |
| flex-direction: column; | |
| flex-grow: 1; | |
| } |
Also not a fan of those div selectors, but not that I have any better ideas 😅.
There was a problem hiding this comment.
Hmm, I don't love the &, trick as it makes the code less legible at a glance. Just like with .parent-selector &, it means we write less lines of code at the expense of taking longer to decipher what it does 😅 and in this case it doesn't even make a difference in the compiled output so there's no performance gain.
Yeah, the divs are not great; it might be something to look into later - are those divs really needed? If so, should they have classnames? - the last-of-type in particular makes me a bit anxious as it can break really easily 😬
tellthemachines
force-pushed
the
fix/widgets-editor-height
branch
from
c795e4a to
26ad771
Compare
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jun 24, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #32769.
The widgets editor root layout area needs to stretch to full screen height so that clicking on any part of the editor unselects selected blocks.
How has this been tested?
In the Widgets editor, select a block. Make sure widget areas don't take up the whole screen. Check that clicking underneath the widget areas unselects the selected block.
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).