Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legacy custom html widget should have option to transform to custom html block #32862

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Legacy custom html widget should have option to transform to custom html block #32862

merged 1 commit into from
Jun 22, 2021

Conversation

spacedmonkey
Copy link
Member

Description

The keyname for custom html widget is correctly wrong. WordPress core uses the key custom_html and not html.

See
https://github.com/WordPress/wordpress-develop/blob/d0e8b81cd8c43f884ceb234a56f702479ae512a4/src/wp-includes/widgets/class-wp-widget-custom-html.php#L54

How has this been tested?

Screenshots

Screenshot 2021-06-21 at 18 38 45

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

Fixes #32826

@spacedmonkey spacedmonkey added [Feature] Widgets Screen The block-based screen that replaced widgets.php. [Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets labels Jun 21, 2021
@spacedmonkey spacedmonkey self-assigned this Jun 21, 2021
noisysocks
noisysocks approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@noisysocks noisysocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@noisysocks noisysocks added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jun 22, 2021
@noisysocks noisysocks merged commit dc49568 into WordPress:trunk Jun 22, 2021
@github-actions github-actions bot added this to the Gutenberg 11.0 milestone Jun 22, 2021
@noisysocks noisysocks removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jun 22, 2021
noisysocks pushed a commit that referenced this pull request Jun 22, 2021
@spacedmonkey @noisysocks
Legacy custom html widget should have option to transform to custom h…
deced48 
…tml block (#32862)
@noisysocks noisysocks mentioned this pull request Jun 22, 2021
Merged
jorgefilipecosta pushed a commit that referenced this pull request Jun 22, 2021
@spacedmonkey @jorgefilipecosta
Legacy custom html widget should have option to transform to custom h…
9f3b288 
…tml block (#32862)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisysocks noisysocks noisysocks approved these changes

@youknowriad youknowriad Awaiting requested review from youknowriad

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

Assignees

@spacedmonkey spacedmonkey

Labels
[Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets [Feature] Widgets Screen The block-based screen that replaced widgets.php.
Projects
None yet
Milestone
Gutenberg 11.0
Development

Successfully merging this pull request may close these issues.

Legacy custom html widget should have option to transform to custom html block
2 participants
@spacedmonkey @noisysocks