Fix unintended search http request in <LinkControl> #32857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Block] Image
|
Note I came across this bug when trying to debug the failing Image block e2e tests on #32732 |
7 tasks
|
Size Change: -1 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
kevin940726
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
showSuggestionsprop is passed to<LinkControl>the consumer should expect that the component will not make any HTTP requests for search suggestions.At first glance this appears to be the case, but if we observe the Network tab we can see that in fact due to an error in the logic within the component, the default search handler attached to the block editor settings is invoked.
This PR fixes things so that if
showSuggestionsisfalsethen the default "noop" handler is invoked and no HTTP is made.This issue is what is currently causing flaky e2e tests in the Image block.
How has this been tested?
To manually test:
On Trunk
Replaceon the Image block.Editbutton that appears.searchendpoint in the Network tab.On this PR
Replaceon the Image block.Editbutton that appears.Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).