Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the case of navigation __unstableLocation #32783

Merged
merged 2 commits into from
Jun 18, 2021
Merged

Correct the case of navigation __unstableLocation #32783

merged 2 commits into from
Jun 18, 2021

Conversation

draganescu
Copy link
Contributor

@draganescu draganescu commented Jun 17, 2021 •
edited
Loading

I did not pay attention when reviewing and #32491 got merged with a wrong casing for the new __unstableLocation attribute. This PR fixes that.

@draganescu draganescu requested a review from ajitbohra as a code owner June 17, 2021 14:22
@draganescu draganescu self-assigned this Jun 17, 2021
@draganescu draganescu added [Type] Code Quality Issues or PRs that relate to code quality [Type] Task Issues or PRs that have been broken down into an individual action to take labels Jun 17, 2021
@draganescu draganescu mentioned this pull request Jun 17, 2021
Merged
7 tasks
@scruffian scruffian mentioned this pull request Jun 17, 2021
Closed
7 tasks
scruffian
scruffian approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@scruffian scruffian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing.

@draganescu draganescu merged commit c405fe0 into trunk Jun 18, 2021
@draganescu draganescu deleted the fix/navigation_location_case branch June 18, 2021 07:11
@github-actions github-actions bot added this to the Gutenberg 11.0 milestone Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scruffian scruffian scruffian approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@draganescu draganescu

Labels
[Type] Code Quality Issues or PRs that relate to code quality [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
Gutenberg 11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@draganescu @scruffian