Implement basic in memory cache for rich link previews data #32741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
the
[Feature] Link Editing
|
Size Change: +23 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
draganescu
reviewed
Jun 17, 2021
packages/editor/src/components/provider/use-block-editor-settings.js
Outdated
Show resolved
Hide resolved
getdave
force-pushed
the
try/memory-cache-of-rich-url-data
branch
from
13e7602 to
8d986c9
Compare
|
I have no idea what happened to this PR... I didn't hit merge intentionally. |
|
Let's try reopening... |
|
@kevin940726 @draganescu Now uses
Let me know what you think and if this tests ok for you. |
kevin940726
reviewed
Jun 18, 2021
packages/core-data/src/fetch/__experimental-fetch-remote-url-data.js
Outdated
Show resolved
Hide resolved
kevin940726
approved these changes
Jun 18, 2021
packages/core-data/src/fetch/__experimental-fetch-remote-url-data.js
Outdated
Show resolved
Hide resolved
|
@kevin940726 I also added some automated test coverage. This was prompted by the additional complexity of adding the cache. |
getdave
force-pushed
the
try/memory-cache-of-rich-url-data
branch
from
3251f37 to
8df338e
Compare
This comment has been minimized.
This comment has been minimized.
getdave
force-pushed
the
try/memory-cache-of-rich-url-data
branch
from
706ef38 to
71072dd
Compare
getdave
force-pushed
the
try/memory-cache-of-rich-url-data
branch
from
71072dd to
bb3a9f2
Compare
|
Rebasin...again... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, each time you preview an external URL an HTTP request is made to the REST API for that data. For some people this could be additional bandwidth that they don't want to expend.
To avoid this, this PR implements a very simple in-memory (only) cache on a per-URL basis.
If the URL has been previewed before for the same request then the same data-set will be returned from the local cache.
As this dataset is cached at a block editor settings level we don't loose the information between mounting/unmounting of the
<LinkControl>component.I'm not feeling great about burdening the block editor settings with yet more rich preview related code so any suggestions or improvements are most welcome.
Fixes #32554
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).