Try: Align widget sidebar button. #32738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
the
CSS Styling
|
Size Change: +15 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
|
|
||
| .dashicon { | ||
| display: inline-block; | ||
| flex: 0 0 auto; | ||
| } | ||
|
|
||
| // Pull left if the tertiary button stands alone after a description, so as to vertically align with items above. |
There was a problem hiding this comment.
It seems strange that the styles of a button depend on if the button follows a paragraph or not. Is this change something that should happen all the time if before the button there is a paragraph?
For the other button styles would this change or something similar also make sense?
What if instead of adding these styles to the button we add them to the container of the description and button (widget areas block)?
There was a problem hiding this comment.
The thing is, the tertiary button has a built-in padding of 6px, which means it needs the similar negative margin only if it stands on its own. In the Image block example shown (primary, tertiary, tertiary) the button should not have negative margin.
There was a problem hiding this comment.
Thank you for the clarification 👍
draganescu
approved these changes
Jun 18, 2021
|
@jasmussen what do you say about moving this link to the head of the editor, somewhere next to the update button or similar? |
|
Thank you for the review!
I think part of the reason why I think the sidebar, and for a tertiary style for this button, is to manage the prominence. You can find it if you need it, but I don't think it should have increased prominence because it's such a different interaction and interface. If the codebase for widgets was different, making it more of a direct split screen toggle rather than a jarring shift loading an entirely new webpage, the top toolbar could make more sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Very small improvement to the Button component, specifically the tertiary style, so that it aligns vertically if shown next to a description. For example in the new widgets editor, before:
After:
How has this been tested?
This negative margin for alignment should only apply in the right contexts. In my testing, it does, but please look for any tertiaty buttons that look pulled left when they shouldn't be.
Checklist:
*.native.jsfiles for terms that need renaming or removal).