Fix: Allow decimals in spacing controls #32692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +18 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
aristath
changed the title
aristath
force-pushed
the
add/units-default-steps
branch
from
91c2752 to
9eedbb8
Compare
aristath
added
[Type] Bug
aristath
changed the title
aristath
force-pushed
the
add/units-default-steps
branch
from
9eedbb8 to
f10a9ef
Compare
7 tasks
7 tasks
This was referenced Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #31964
The issue was that units don't have a
stepdefined, and also that on change the NumberControl rounds all numbers to integers when instead it should take into account the definedstepin the control.After #30376 got merged, CSS units should have a
stepdefined. This PR adds a reasonable step for all CSS units:px,pc,pt%,vw,vh,vmin,vmax,mmem,rem,ch,excm,inChecklist:
*.native.jsfiles for terms that need renaming or removal).