Ensure only valid URLs or anchors within text are automatically created as links

[tjcafferkey]

Fixes #32301

Description

• Used isValidHref within addLink function to check the validity of selected text

How has this been tested?

• Create or edit an existing post.
• Add text that has a ": " within it such as this: is invalid text
• Highlight and select the text, then click the Link icon to link the selected text
• Check that the highlighted text isn't auto-populated in the input field as the destination URL.

Unit tests also included.

Before	After

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• I've tested my changes with keyboard and screen readers.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

[github-actions]

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @tjcafferkey! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

[getdave]

I think isValidHref should be moved to @wordpress/url. @talldan any thoughts on that? isUrl is fairly lenient on what you might consider a valid URL.

[getdave]

Hi Tom 👋

Thanks for contributing to Gutenberg 😄

This looks good to me and seems like a positive change.

I wonder whether you'd consider adding an e2e test to cover this scenario?

https://github.com/WordPress/gutenberg/blob/trunk/packages/e2e-tests/specs/editor/various/links.test.js

All the building blocks should be there in the other tests.

npm run test-e2e packages/e2e-tests/specs/editor/various/links.test.js should run the tests. There are docs on testing as well with a section on e2e tests.

[tjcafferkey]

I wonder whether you'd consider adding an e2e test to cover this scenario?

Yeah shouldn't be a problem :) I'll update the PR soon with some E2E coverage. Thanks for pointing me in the right direction.

[getdave]

Thanks so much for the e2e test. Some small ideas and then we're good to go.

[talldan]

I think isValidHref should be moved to @wordpress/url. @talldan any thoughts on that? isUrl is fairly lenient on what you might consider a valid URL.

It wasn't moved there originally because the function validates anchor links, which aren't URLs. Maybe that isn't a strong enough reason not to move it there, but I think it shouldn't be confused with a URL checker.

[getdave]

Looking good @tjcafferkey 🥇

Thanks for contributing 🤝

[github-actions]

Congratulations on your first merged pull request, @tjcafferkey! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

[talldan]

This also fixed #33009 🎉

Thanks for the contribution @tjcafferkey.