Try: Fix vertical scroll in horizontal toolbar. #32655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
the
CSS Styling
|
Size Change: +10 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some block toolbars can grow long. Like Image or List. Pending better solutions (custom styled scrollbar?), we currently allow a horizontal scrollbar to let you scroll the toolbar. However this also causes a vertical scrollbar in some cases:
This PR serves as a small fix to remove that vertical scrollbar:
As far as I can tell, this fixes the issue entirely, i.e. even using touch controls there isn't actually any space to scroll vertically. So the fact that the vertical toolbar appeared seems circular: it's there to let you scroll to see space that was made necessary by the presence of a vertical scrollbar.
How has this been tested?
Insert a list and/or an image. Make the viewport small or test on a mobile device. Observe a horizontal, but not vertical scrollbar, in the block toolbar.
Checklist:
*.native.jsfiles for terms that need renaming or removal).