Fix component inspector error in React Native #32628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An issue cropped up where the inspector (Debug Menu > Show Inspector) showed a red screen when loading. This happens because on loading the inspector, a hook is called which checks the editor capabilities. If the reusable block capability is `false`, the reusable block type is then unregistered. What seems to happen when opening the inspector is that the editor does not fully reload, so the reusable block is already unregistered and the app tries to unregister it again, causing a red screen. The fix here is to only unregister the block if it's currently registered. An alternative approach might be to put the code that unregisters the block in a hook that's only called when the editor is first loaded, not when it's only partially reloaded by the inspector.
|
Size Change: 0 B Total Size: 1.04 MB ℹ️ View Unchanged
|
guarani
added
the
Mobile App - i.e. Android or iOS
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An issue cropped up where the inspector (Debug Menu > Show Inspector) showed a red screen when loading. This happens because on loading the inspector, a hook is called which checks the editor capabilities. If the reusable block capability is
false, the reusable block type is then unregistered.What seems to happen when opening the inspector is that the editor does not fully reload, so the reusable block is already unregistered and the app tries to unregister it again, causing a red screen.
The fix here is to only unregister the block if it's currently registered. An alternative approach might be to put the code that unregisters the block in a hook that's only called when the editor is first loaded, not when it's only partially reloaded by the inspector.
See wordpress-mobile/gutenberg-mobile#3612
How has this been tested?
I tested the inspector on both the Android and iOS Gutenberg demo apps.
Screenshots
Not applicable.
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).