Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block categories: Clean these up by moving several blocks from Design to Theme #32568

Merged
merged 18 commits into from
Jun 17, 2021

Conversation

kellychoffman
Copy link
Contributor

Cleaning up the block categories within the Block Inserter. This PR moves the following blocks from the Design category to the Theme category, based on the intended usage of the blocks.

  • Navigation (vertical)
  • Navigation (horizontal)
  • Login/out
  • Query
  • Post Title
  • Post Content
  • Post Date
  • Post Excerpt
  • Post Featured Image
  • Post Author
  • Post Comment
  • Post Comments
  • Post Comments Count
  • Post Comments Form
  • Post Comments Link
  • Term Description
  • Next post
  • Previous post

@kellychoffman kellychoffman requested a review from ajitbohra as a code owner June 9, 2021 22:42
@annezazu annezazu added [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Enhancement A suggestion for improvement. labels Jun 9, 2021
@shaunandrews
Copy link
Contributor

I wonder if "Theme" could be confused as meaning "provided by your theme."

@priethor
Copy link
Contributor

I wonder if "Theme" could be confused as meaning "provided by your theme."

My first thought was similar back when the category was created in #30016, but categories should not address a block's origin but their content; similarly, we don't have a "plugins" category.

Copy link
Contributor

@priethor priethor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. In #30016 it was suggested to leave widget-like blocks (Site Logo, Title, etc) in the widgets section, so waiting for @mtias to confirm.

As a side note, if we do move these blocks to "Themes" we will have:

  • Posts List block under "Themes"
  • Latest Posts and Page List blocks under "Widgets".

Having these similarly named blocks in different categories can be confusing for users, but I don't think this should be a blocker as these widget blocks might be replaced in the future by more Query block variations (#32332).

@priethor priethor added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jun 10, 2021
@kellychoffman kellychoffman requested a review from priethor June 15, 2021 22:44
@priethor priethor force-pushed the update/move-blocks-to-theme-cat branch from 53ea52c to 758c1c6 Compare June 16, 2021 17:38
@jasmussen
Copy link
Contributor

Got the tests passing on this one! Feel free to press the green button 👌

@priethor priethor merged commit bc35ea9 into trunk Jun 17, 2021
@priethor priethor deleted the update/move-blocks-to-theme-cat branch June 17, 2021 09:23
@github-actions github-actions bot added this to the Gutenberg 11.0 milestone Jun 17, 2021
@youknowriad youknowriad removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jun 21, 2021
youknowriad pushed a commit that referenced this pull request Jun 21, 2021
… to Theme (#32568)

* navigation: update category from Design to Theme

* loginout: update category from Design to Theme

* query: update category from Design to Theme

* post title: update category from Design to Theme

* post content: update category from Design to Theme

* post date: update category from Design to Theme

* post excerpt: update category from Design to Theme

* post featured image: update category from Design to Theme

* post author: update category from Design to Theme

* post comment: update category from Design to Theme

* post comments: update category from Design to Theme

* post comments count: update category from Design to Theme

* post comments form: update category from Design to Theme

* post comments link: update category from Design to Theme

* term description: update category from Design to Theme

* nextpage: update category from Design to Theme

* break: undo category change

* post navigation link: update category from Design to Theme
youknowriad pushed a commit that referenced this pull request Jun 21, 2021
… to Theme (#32568)

* navigation: update category from Design to Theme

* loginout: update category from Design to Theme

* query: update category from Design to Theme

* post title: update category from Design to Theme

* post content: update category from Design to Theme

* post date: update category from Design to Theme

* post excerpt: update category from Design to Theme

* post featured image: update category from Design to Theme

* post author: update category from Design to Theme

* post comment: update category from Design to Theme

* post comments: update category from Design to Theme

* post comments count: update category from Design to Theme

* post comments form: update category from Design to Theme

* post comments link: update category from Design to Theme

* term description: update category from Design to Theme

* nextpage: update category from Design to Theme

* break: undo category change

* post navigation link: update category from Design to Theme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants