-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block categories: Clean these up by moving several blocks from Design to Theme #32568
Conversation
I wonder if "Theme" could be confused as meaning "provided by your theme." |
My first thought was similar back when the category was created in #30016, but categories should not address a block's origin but their content; similarly, we don't have a "plugins" category. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. In #30016 it was suggested to leave widget-like blocks (Site Logo, Title, etc) in the widgets section, so waiting for @mtias to confirm.
As a side note, if we do move these blocks to "Themes" we will have:
- Posts List block under "Themes"
- Latest Posts and Page List blocks under "Widgets".
Having these similarly named blocks in different categories can be confusing for users, but I don't think this should be a blocker as these widget blocks might be replaced in the future by more Query block variations (#32332).
53ea52c
to
758c1c6
Compare
Got the tests passing on this one! Feel free to press the green button 👌 |
… to Theme (#32568) * navigation: update category from Design to Theme * loginout: update category from Design to Theme * query: update category from Design to Theme * post title: update category from Design to Theme * post content: update category from Design to Theme * post date: update category from Design to Theme * post excerpt: update category from Design to Theme * post featured image: update category from Design to Theme * post author: update category from Design to Theme * post comment: update category from Design to Theme * post comments: update category from Design to Theme * post comments count: update category from Design to Theme * post comments form: update category from Design to Theme * post comments link: update category from Design to Theme * term description: update category from Design to Theme * nextpage: update category from Design to Theme * break: undo category change * post navigation link: update category from Design to Theme
… to Theme (#32568) * navigation: update category from Design to Theme * loginout: update category from Design to Theme * query: update category from Design to Theme * post title: update category from Design to Theme * post content: update category from Design to Theme * post date: update category from Design to Theme * post excerpt: update category from Design to Theme * post featured image: update category from Design to Theme * post author: update category from Design to Theme * post comment: update category from Design to Theme * post comments: update category from Design to Theme * post comments count: update category from Design to Theme * post comments form: update category from Design to Theme * post comments link: update category from Design to Theme * term description: update category from Design to Theme * nextpage: update category from Design to Theme * break: undo category change * post navigation link: update category from Design to Theme
Cleaning up the block categories within the Block Inserter. This PR moves the following blocks from the Design category to the Theme category, based on the intended usage of the blocks.