Quality: Promote lint rule to error when validating store string literals #32537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is still 6 errors to fix: I figured out that
gutenberg/packages/server-side-render/src/index.js Lines 19 to 20 in 8d5139d It's worth noting that I see it used with the following blocks:
|
17 tasks
|
Size Change: +4 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
gziolo
added
[Type] Code Quality
gziolo
changed the title
|
@youknowriad, is 974557a correct? I would appreciate your guidance here. |
|
@gziolo that commit looks correct to me 👍 |
gziolo
force-pushed
the
update/error-no-store-string-literals
branch
from
974557a to
6f9ba12
Compare
It looks like it only needs to provide the current post id when in the context of the post type editor as introduced in #9323. It looks like something that could be read from the context rather than through the selector. |
gziolo
force-pushed
the
update/error-no-store-string-literals
branch
from
6f9ba12 to
58aab25
Compare
This was referenced Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #27088.
This is the last step to replace hardcoded store keys with store definitions. This PR promotes
@wordpress/data-no-store-string-literalsESLint rule to the error level.How has this been tested?
npm run lint-js -- --quietTypes of changes
Code quality.