Try to fix RN 0.64 upgrade WPAndroid insert link crash #32517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebase
Use accessibility label to find TextInput component instead of the class name. The class name fails because the way TextInput is implemented in 0.62 where a ForwardRef is used.
Add isFocused method to mock of TextInput.
Changes after install on clean clone change
# Conflicts: # package-lock.json
# Conflicts: # package-lock.json
# Conflicts: # package-lock.json
# Conflicts: # package-lock.json # packages/react-native-editor/ios/Podfile.lock # packages/react-native-editor/package.json # packages/scripts/scripts/check-licenses.js
# Conflicts: # packages/react-native-editor/ios/Podfile.lock
2 tasks
hypest
changed the title
|
Size Change: -1.45 kB (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
|
For the record, tried the WPAndroid installable build built off c9ef53c and it doesn't crash for me when trying to add a link inside a paragraph by tapping on the link toolbar button! 🎉 |
|
Updated from Gutenberg trunk to mainly bring in the LinkControl fix which we hope has fixed the web side e2e tests. |
hypest
force-pushed
the
rnmobile/try/upgrade-0-64-hypest
branch
from
db67222 to
1cd20a9
Compare
13 tasks
|
No need for this PR anymore, the main RN 0.64 upgrade PR that includes the fixes from this PR has been merged and the links to the dep forks are there too so, closing this 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#3597
Dependency upgrades
The following deps have JitPack builds that directly use a RN binary version other than 0.64 so, need to align them with the rest of gutenberg-mobile
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).