Second batch of backports for WP 5.8 beta 1 #32484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…32352) Other than making sure that the class doesn't contain spaces we no longer do any processing in the client (camelCase to kebab-case, separate numbers as a different kebab word, etc).
* Update the appearance of the template details popover * Tweaks * use secondary variant for delete button
…32341) * Prevent saving the post before previewing in locked/read-only mode. * Fix nit, remove extra comment.
Co-authored-by: ntsekouras <[email protected]>
* fixes #24710 * Additional test * typo * fix failing tests * update test description * update docs
Squashed commits: [ce2c0f8856] Update lib/block-supports/typography.php Co-authored-by: André <[email protected]> [a27fe6e2c7] Update: Typography supports shape.
* change site-logo sync hook * Don't pollute the global variables Co-authored-by: Weston Ruter <[email protected]> * cs * Hook in setup_theme Co-authored-by: Weston Ruter <[email protected]>
* add `value` to dependencies * Add the variables used in setRecordFromProps to dependencies. * use _value.current instead of value * revert change * add tagName to __unstableDependencies * add e2e test. * format * fix snapshot
youknowriad
requested review from
ajitbohra,
cameronvoell,
chrisvanpatten and
draganescu
as code owners
youknowriad
requested review from
ellatrix,
guarani,
kevin940726,
nerrad,
noisysocks,
oandregal,
ntwb,
spacedmonkey,
talldan,
tellthemachines and
TimothyBJacobs
as code owners
|
Size Change: +667 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
* Avoid keeping the same client ID when transforming blocks * Fix unit tests
2 tasks
| */ | ||
| function gutenberg_migrate_old_typography_shape( $metadata ) { | ||
| // Temporarily disable migrations from core blocks until core block.json are updated. | ||
| if ( isset( $metadata['supports'] ) && false === strpos( $metadata['file'], '/wp-includes/blocks/' ) ) { |
There was a problem hiding this comment.
After core json files are updared we should remove this check && false === strpos( $metadata['file'], '/wp-includes/blocks/'.
There was a problem hiding this comment.
@jorgefilipecosta mind doing a follow-up commit?
There was a problem hiding this comment.
mmm, was perhaps something wrong with the merging? I remember having removed that check and actually the function had a different name wp_migrate_old_typography_sahpe youknowriad/wordpress-develop@4fb3e5a#diff-8c99af92e4ec0fdb307ddd9b42be1e1ef1efe4a9f31287c23f346244dddd1ce9R959
There was a problem hiding this comment.
Oh, sorry, this is the gutenberg repo 😅 So many places to check that I was confused for a moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this includes the following:
Backport 2
Widgets Editor:
Widget blocks in the customizer:
Global Styles:
typographykey #32252 Update: Skip typography serialization #32444 Letter spacing should also respect skip serialization flag #32459theme.jsonvisible to users #32404Template Editor:
Miscellaneous:
Performance: