Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to the Track ticket 53301
All the classic widgets have been replaced by blocks and hence the decision to hide them from being used makes sense. However the "Navigation Menu" widget is not fully replaced by the
Navigation
because theNavigation
block is currently missing the ability to update itself if a classic menu has been changed. TheNavigation
block can only import a classic menu, creating a static copy of it. This behavior is different and unexpected in the widgets context.While the
LegacyWidget
block does display the "Navigation Menu" widget, adding new ones is not possible without this change. It should be possible, considering we don't even have a transform yet from the "Navigation Menu" widget to theNavigatioin
block, liike all the other core classic widgets do.How has this been tested?
Screenshots
Types of changes
Removed the
nav_menu
widget from thewidget_types_to_hide_from_legacy_widget_block
filter.Also fixed a typo in a comment.