-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update the block toolbar ESnext code. #32422
Conversation
the current code seems not working.
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @bhvreddy! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Hello @bhvreddy, thank you for working on this! I haven't tested the changes yet, I just took a quick look at the diff. Could you please revert the spacing changes in this PR? Extra spaces are always used as per the WordPress Coding Standards to improve code readability 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated spaces - format
Hi, Thank you for the contribution; I tested your changes in a new block; and they work for me! :) The current tutorial code in trunk (found at https://developer.wordpress.org/block-editor/how-to-guides/block-tutorial/block-controls-toolbar-and-sidebar/#block-toolbar ) had not. I'm rusty on es5... I checked that code and I don't think that needs any changes to it (the existing code works for me) but would appreciate a second look. |
I tested the es5 code, its works fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing it.
Congratulations on your first merged pull request, @bhvreddy! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
the current code seems not working. but please check and proced. ( i am just started learning block editor )
Description
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.js
files for terms that need renaming or removal).