Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the block toolbar ESnext code. #32422

Merged
merged 4 commits into from
Jun 18, 2021
Merged

update the block toolbar ESnext code. #32422

merged 4 commits into from
Jun 18, 2021

Conversation

bhvreddy
Copy link
Contributor

@bhvreddy bhvreddy commented Jun 3, 2021

the current code seems not working. but please check and proced. ( i am just started learning block editor )

Description

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

the current code seems not working.
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jun 3, 2021
@github-actions
Copy link

github-actions bot commented Jun 3, 2021

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @bhvreddy! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@aristath
Copy link
Member

aristath commented Jun 3, 2021

Hello @bhvreddy, thank you for working on this!

I haven't tested the changes yet, I just took a quick look at the diff. Could you please revert the spacing changes in this PR? Extra spaces are always used as per the WordPress Coding Standards to improve code readability 👍

Copy link
Contributor Author

@bhvreddy bhvreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated spaces - format

@aristath aristath added the [Type] Developer Documentation Documentation for developers label Jun 4, 2021
@skorasaurus
Copy link
Member

skorasaurus commented Jun 11, 2021

Hi,

Thank you for the contribution; I tested your changes in a new block; and they work for me! :) The current tutorial code in trunk (found at https://developer.wordpress.org/block-editor/how-to-guides/block-tutorial/block-controls-toolbar-and-sidebar/#block-toolbar ) had not.

I'm rusty on es5... I checked that code and I don't think that needs any changes to it (the existing code works for me) but would appreciate a second look.

@bhvreddy
Copy link
Contributor Author

I tested the es5 code, its works fine.

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it.

@gziolo gziolo merged commit 4ed6fd3 into WordPress:trunk Jun 18, 2021
@github-actions
Copy link

Congratulations on your first merged pull request, @bhvreddy! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 11.0 milestone Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants