[Block Conversion - Embed]: Fix embed to paragraph transform when caption has rich text formats #32355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
commented
May 31, 2021
|
Size Change: -25 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
…n has rich text formats
ntsekouras
force-pushed
the
fix/embed-to-paragraph-with-caption-transform
branch
from
9d63fdb to
718cb90
Compare
ellatrix
reviewed
Jun 10, 2021
| transform: ( { url, caption } ) => { | ||
| const link = <a href={ url }>{ caption || url }</a>; | ||
| return createBlock( 'core/paragraph', { | ||
| content: renderToString( link ), |
ellatrix
approved these changes
Jun 10, 2021
ellatrix
reviewed
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #32265
Currently when we have an
embedblock and we have added rich text formats to its caption (bold, link, color, etc..), if we transform to aparagraphall the html tags will be pulled into the text node. This PR solves that.In addition I have added an
isMatchfor this transform, so it is shown only if we have aurl. You can test the existing behavior by inserting aYoutubeblock without adding aurland observe that the convert to paragraph option is available.Testing instructions
Checklist:
*.native.jsfiles for terms that need renaming or removal).