BoxControl: Add allowReset option #32345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
aaronrobertshaw
requested review from
ajitbohra and
chrisvanpatten
as code owners
|
Size Change: +17 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #28356
Description
As part of moving towards the new "Dimensions" panel where block support controls when toggled off are reset, the BoxControl reset button is superfluous. To reduce clutter in the controls it would be nice to have a means of not rendering it.
This PR:
allowResetoption on theBoxControlthat defaults totrueallowResetistrue.BoxControldocs for the new option as well as the missingresetValuespropHow has this been tested?
Manually.
Testing instructions
packages/block-editor/src/hooks/padding.jsand add anallowReset={ false }prop to theBoxControl- gistScreenshots
Types of changes
New feature.
Checklist:
*.native.jsfiles for terms that need renaming or removal).