Block editor: use React events for shortcuts (portal bubbles & contextual) #32323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
adamziel,
draganescu,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
|
Size Change: +10 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
move/block-editor-shortcuts-synthetic-events
branch
from
15ac136 to
4c1f6c5
Compare
draganescu
previously approved these changes
Jun 2, 2021
|
Unfortunately in Safari the shortcuts are picked up by the browser even in editor context (e.g. cmd + D opens the bookmark dialog, cmd option shift t opens the profiling in Inspector). |
ellatrix
force-pushed
the
move/block-editor-shortcuts-synthetic-events
branch
2 times, most recently
from
8f3c243 to
ecdea3f
Compare
ellatrix
force-pushed
the
move/block-editor-shortcuts-synthetic-events
branch
from
652df47 to
7636e79
Compare
ellatrix
force-pushed
the
move/block-editor-shortcuts-synthetic-events
branch
from
7636e79 to
2d6754a
Compare
|
This is a big departure in terms of APIs for the shortcuts package, I think it'd have deserved more eyes a bit. For instance
I don't think that makes sense for all shortcuts, some of the shortcuts are I also kind of like the |
youknowriad
reviewed
Jul 26, 2021
| @@ -192,66 +192,65 @@ export default function VisualEditor( { styles } ) { | |||
| }, [ isTemplateMode, themeSupportsLayout, contentSize, wideSize ] ); | |||
|
|
|||
| return ( | |||
| <div | |||
| <BlockTools | |||
There was a problem hiding this comment.
For me if this needs to be a parent of the block editor, it needs to be documented properly in the block-editor package and the documentation we have to build third-party block editors.
That said, the naming is not great at all, shouldn't be BlockEditorWrapper or something like that? Also, if it's a wrapper, why not just bundle it in BlockEditorProvider
There was a problem hiding this comment.
Why does it need to be higher up the tree? Agreed on the documentation, I should add some.
There was a problem hiding this comment.
I don't understand the question. My main motivation here is that it seems we're requiring two wrappers where we can require just one. Unless I'm not understanding properly both these components should wrap the editor canvas? Maybe more granularity is needed, but it's not clear from the user's perspective where to put each one of these components.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Builds on #32318.
Moves shortcut handlers from native events to React events for two reasons:
document). This is important because you may have other things on the page beside the block editor, or multiple block editors. Shortcuts should only work if focus is within a certain context. Using React evens works nicely because they bubble both through the iframe and other portals such as the inspector.Lastly, it removes some boilerplate for implementing a block editor, building
<BlockEditorKeyboardShortcuts />into<BlockTools />.How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).