compose: Add types to useDragging
#32285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Type] Code Quality
|
Size Change: -3 B (0%) Total Size: 1.85 MB
ℹ️ View Unchanged
|
tyxla
reviewed
May 28, 2021
| @@ -8,6 +8,12 @@ import { useCallback, useEffect, useRef, useState } from '@wordpress/element'; | |||
| */ | |||
| import useIsomorphicLayoutEffect from '../use-isomorphic-layout-effect'; | |||
|
|
|||
| /** | |||
| * @param {Object} props | |||
| * @param {(e: MouseEvent) => void} props.onDragStart | |||
There was a problem hiding this comment.
I'm assuming we intentionally use MouseEvent instead of DragEvent?
There was a problem hiding this comment.
Yeah, onDragStart gets passed to onmousedown instead of ondrag actually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds types to
useDragging. There are no real runtime changes except to explicitly pass through the event parameter instead of using...args. Using varargs was not necessary in this case (there's only ever one parameter, the event).Part of #18838
How has this been tested?
Type checks pass.
Types of changes
New feature.
Checklist:
*.native.jsfiles for terms that need renaming or removal).