Performance Tests Workflow: Polish Bash script #32284
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR consists of three commits:
Avoid non-POSIX
grep -P
grep -P
is a GNU extension to use PCRE regular expressions. While it is commonly available on GNU/Linux systems, it is not POSIX and cannot be guaranteed to exist. By replacing it with POSIX-compliant AWK, this workflow is easier to test locally on different systems, including all BSD-derived ones.Use safer or more modern Bash
$(( ... ))
over antiquatedexpr
read
options... just becauseAs a general note, Shellcheck is an excellent tool for linting and validating shell scripts.
Explicitly require Bash shell
The
run
block for the "Compare performance with current WordPress Core and previous Gutenberg versions" job relies on a series of Bashisms (e.g.<<<
syntax, arrays), so we should make that an explicit requirement.Types of changes
Checklist:
*.native.js
files for terms that need renaming or removal).