Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

components: Delete unused types from context #32254

Merged
merged 1 commit into from
May 27, 2021
Merged

components: Delete unused types from context #32254

merged 1 commit into from
May 27, 2021

Conversation

sarayourfriend
Copy link
Contributor

Description

These types were only used when we were creating our own styled object. Given we're no longer doing that, we can remove these types altogether.

How has this been tested?

Type checks pass (only changes are type removals).

Types of changes

Clean up.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • [N/A] My code follows the accessibility standards.
  • [N/A] I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@sarayourfriend sarayourfriend added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components [Feature] Component System WordPress component system labels May 26, 2021
@sarayourfriend sarayourfriend self-assigned this May 26, 2021
tyxla
tyxla approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sarayourfriend sarayourfriend merged commit 8bd99a6 into trunk May 27, 2021
@sarayourfriend sarayourfriend deleted the remove/unused-polymorphic-component-types branch May 27, 2021 13:04
@github-actions github-actions bot added this to the Gutenberg 10.8 milestone May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyxla tyxla tyxla approved these changes

@ciampo ciampo Awaiting requested review from ciampo

@diegohaz diegohaz Awaiting requested review from diegohaz

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

Assignees

@sarayourfriend sarayourfriend

Labels
[Feature] Component System WordPress component system [Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 10.8
Development

Successfully merging this pull request may close these issues.
2 participants
@sarayourfriend @tyxla