Skip tests that are failing with latest WordPress core #32228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
approved these changes
May 26, 2021
|
Size Change: 0 B Total Size: 1.86 MB ℹ️ View Unchanged
|
7 tasks
youknowriad
pushed a commit
that referenced
this pull request
May 31, 2021
iandunn
added a commit
to iandunn/gutenberg
that referenced
this pull request
Jul 13, 2021
The tests were failing in `wp-env` because the latest Core updates had not been backported, so they were disabled in WordPress#32228. Now that the updates are backported, the tests pass again.
ryelle
added a commit
that referenced
this pull request
Jul 13, 2021
* Pattern Directory: Send locale, version with remote pattern requests. This information is needed by the w.org API for translation and caching. Merges https://core.trac.wordpress.org/changeset/51206 See https://core.trac.wordpress.org/ticket/53435 Co-authored-by: Dion Hulse <[email protected]> Co-authored-by: Kelly Dwan <[email protected]> Co-authored-by: tellyworth <[email protected]> * Pattern Directory: Move caching to endpoint for unique responses. Now that the pattern API request includes the locale and version, the cache key needs to contain a hash of the query args. Merges https://core.trac.wordpress.org/changeset/51208 See https://core.trac.wordpress.org/ticket/53435 Co-authored-by: Dominik Schilling <[email protected]> Co-authored-by: Dion Hulse <[email protected]> Co-authored-by: Timothy Jacobs <[email protected]> * Pattern Directory: Enable PHPUnit tests. The tests were failing in `wp-env` because the latest Core updates had not been backported, so they were disabled in #32228. Now that the updates are backported, the tests pass again. * Pattern Directory: Add Core's `should_load_remote_block_patterns` filter. The filter was added to Core during the process of syncing it with Gutenberg, but wasn't backported to Gutenberg until now. See https://core.trac.wordpress.org/ticket/53246 Co-authored-by: Kelly Dwan <[email protected]> Co-authored-by: Dion Hulse <[email protected]> Co-authored-by: Kelly Dwan <[email protected]> Co-authored-by: tellyworth <[email protected]> Co-authored-by: Dominik Schilling <[email protected]> Co-authored-by: Timothy Jacobs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There're some tests that are failing due to updates in the latest WordPress core we use in
wp-env. Skipping them for now so the rest of CI jobs can pass for in-flight PRs.