core-data: no-string-literals fix #32198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.86 MB ℹ️ View Unchanged
|
oandregal
approved these changes
May 26, 2021
aristath
force-pushed
the
fix/no-string-literals/core-data
branch
from
921fbc8 to
b1b5311
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes eslint warnings in the core-data package, replaces string literals with store definitions.
Part of #27088.
How has this been tested?
npm run lint-js packages/core-data/no longer throws warnings for string literalsChecklist:
*.native.jsfiles for terms that need renaming or removal).